lkml.org 
[lkml]   [2010]   [Sep]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RESEND PATCH v2] compaction: fix COMPACTPAGEFAILED counting
On Thu,  2 Sep 2010 23:34:47 +0900
Minchan Kim <minchan.kim@gmail.com> wrote:

> Now update_nr_listpages doesn't have a role. That's because
> lists passed is always empty just after calling migrate_pages.
> The migrate_pages cleans up page list which have failed to migrate
> before returning by aaa994b3.
>
> [PATCH] page migration: handle freeing of pages in migrate_pages()
>
> Do not leave pages on the lists passed to migrate_pages(). Seems that we will
> not need any postprocessing of pages. This will simplify the handling of
> pages by the callers of migrate_pages().
>
> At that time, we thought we don't need any postprocessing of pages.
> But the situation is changed. The compaction need to know the number of
> failed to migrate for COMPACTPAGEFAILED stat
>
> This patch makes new rule for caller of migrate_pages to call putback_lru_pages.
> So caller need to clean up the lists so it has a chance to postprocess the pages.
> [suggested by Christoph Lameter]

I'm having trouble predicting what the user-visible effects of this bug
might be. Just an inaccuracy in the COMPACTPAGEFAILED vm event?



\
 
 \ /
  Last update: 2010-09-04 02:07    [W:0.039 / U:0.932 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site