Messages in this thread | | | Date | Fri, 3 Sep 2010 17:02:27 -0700 | From | Andrew Morton <> | Subject | Re: [RESEND PATCH v2] compaction: fix COMPACTPAGEFAILED counting |
| |
On Thu, 2 Sep 2010 23:34:47 +0900 Minchan Kim <minchan.kim@gmail.com> wrote:
> Now update_nr_listpages doesn't have a role. That's because > lists passed is always empty just after calling migrate_pages. > The migrate_pages cleans up page list which have failed to migrate > before returning by aaa994b3. > > [PATCH] page migration: handle freeing of pages in migrate_pages() > > Do not leave pages on the lists passed to migrate_pages(). Seems that we will > not need any postprocessing of pages. This will simplify the handling of > pages by the callers of migrate_pages(). > > At that time, we thought we don't need any postprocessing of pages. > But the situation is changed. The compaction need to know the number of > failed to migrate for COMPACTPAGEFAILED stat > > This patch makes new rule for caller of migrate_pages to call putback_lru_pages. > So caller need to clean up the lists so it has a chance to postprocess the pages. > [suggested by Christoph Lameter]
I'm having trouble predicting what the user-visible effects of this bug might be. Just an inaccuracy in the COMPACTPAGEFAILED vm event?
| |