Messages in this thread | | | Date | Fri, 3 Sep 2010 21:24:46 +0200 | From | Dan Carpenter <> | Subject | Re: [PATCH 3/3] Staging: cx25821: fix coding style issue in cx25821-audio-upstream.h, cx25821-core.c, cx25821-i2c.c, cx25821-medusa-reg.h, cx25821-medusa-video.c |
| |
On Sat, Sep 04, 2010 at 12:26:24AM +0600, Gorskin Ilya wrote: > @@ -977,8 +977,8 @@ static int cx25821_dev_setup(struct cx25821_dev *dev) > dev->lmmio = ioremap(dev->base_io_addr, pci_resource_len(dev->pci, 0)); > > if (!dev->lmmio) { > - CX25821_ERR > - ("ioremap failed, maybe increasing __VMALLOC_RESERVE in page.h\n"); > + CX25821_ERR("ioremap failed, > + maybe increasing __VMALLOC_RESERVE in page.h\n"); > cx25821_iounmap(dev); > return -ENOMEM; > }
You didn't try compile this.
> --- a/drivers/staging/cx25821/cx25821-medusa-video.c > +++ b/drivers/staging/cx25821/cx25821-medusa-video.c > @@ -500,8 +500,8 @@ void medusa_set_resolution(struct cx25821_dev *dev, int width, > /* validate the width - cannot be negative */ > if (width > MAX_WIDTH) { > printk > - ("cx25821 %s() : width %d > MAX_WIDTH %d ! resetting to MAX_WIDTH\n", > - __func__, width, MAX_WIDTH); > + ("cx25821 %s() : width %d > MAX_WIDTH %d ! > + resetting to MAX_WIDTH\n", __func__, width, MAX_WIDTH); > width = MAX_WIDTH; > }
The string is damaged here. We don't want those tabs in the final output.
Please look the patch over again and resend. There maybe some other things I missed. Wait a day between writing patches and sending them so that you can review it with fresh eyes.
regards, dan carpenter
| |