lkml.org 
[lkml]   [2010]   [Sep]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCHv11 2.6.36-rc2-tip 3/15] 3: uprobes: Slot allocation for Execution out of line(XOL)
From
Date
On Fri, 2010-09-03 at 22:10 +0530, Srikar Dronamraju wrote:
> > > + vma = find_vma(mm, addr);
> > > +
> > > + /* Don't expand vma on mremap(). */
> > > + vma->vm_flags |= VM_DONTEXPAND | VM_DONTCOPY;
> > > + area->vaddr = vma->vm_start;
> >
> > Seems interesting,.. why not use install_special_mapping(), that's what
> > the VDSO uses.
>
> Okay, I hadnt looked at install_special_mapping earlier so I will take a
> look and incorporate it. However I am not clear at this point what
> install_special_mapping is giving us here. Also install_special_mapping
> is already defining its own vm_ops esp a close method thats doesnt seem
> to be doing anything. So at this point I am not clear how we are link
> the vm_ops, the close method and install_special_mapping.

What you're doing might well be the right thing, I was just wondering.

I think that, after thinking about it more, that the shmem file thing
you're doing has the added benefit that the things gets auto-magic
paging, which is a good thing.




\
 
 \ /
  Last update: 2010-09-03 19:29    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site