Messages in this thread | | | Date | Fri, 3 Sep 2010 08:52:44 -0700 | From | "Paul E. McKenney" <> | Subject | Re: [PATCH] netpoll: use non-BH variant of RCU |
| |
On Fri, Sep 03, 2010 at 08:34:09AM -0700, David Miller wrote: > From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> > Date: Thu, 2 Sep 2010 10:26:25 -0700 > > > softirq: adjust error check > > > > The error check for _local_bh_enable_ip() warns on both in_irq() and > > irqs_disabled(). The check for in_irq() is necessary, because a hardirq > > might well have interrupted bh execution, in which case it is simply > > not possible for the hardirq to exclude the bh that got interrupted. > > > > However, it is perfectly reasonable to disable bh while hardirqs are > > disabled, and this in fact promotes common code. This commit therefore > > removes the irqs_disabled() check. > > > > Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> > > Acked-by: David S. Miller <davem@davemloft.net>
Thank you, David!
Thanx, Paul
| |