Messages in this thread | | | Date | Fri, 3 Sep 2010 11:58:32 +0200 | From | Richard Cochran <> | Subject | Re: [PATCH 1/2] posix clocks: introduce a syscall for clock tuning. |
| |
On Fri, Sep 03, 2010 at 11:29:05AM +0200, Richard Cochran wrote: > +long compat_sys_clock_adjtime(clockid_t which_clock, > + struct compat_timex __user *utp) > +{ > + struct timex txc; > + mm_segment_t oldfs; > + int err, ret; > + > + err = compat_get_timex(&txc, utp); > + if (err) > + return err; > + > + oldfs = get_fs(); > + set_fs(KERNEL_DS); > + ret = sys_clock_adjtime(which_clock, (struct timex __user *) &txc); > + set_fs(oldfs);
I don't know what the purpose of get_fs, set_fs is, but the other clock_ functions have it that way. The adjtimex call does not have this at all, so I ask, do we need this here, or not?
Thanks, Richard
| |