Messages in this thread Patch in this message |  | | | From | Namhyung Kim <> | | Subject | [PATCH 1/3] slub: Fix signedness warnings | | Date | Wed, 29 Sep 2010 21:02:13 +0900 |
| |
The bit-ops routines require its arg to be a pointer to unsigned long. This leads sparse to complain about different signedness as follows:
mm/slub.c:2425:49: warning: incorrect type in argument 2 (different signedness) mm/slub.c:2425:49: expected unsigned long volatile *addr mm/slub.c:2425:49: got long *map
Signed-off-by: Namhyung Kim <namhyung@gmail.com> --- mm/slub.c | 7 +++---- 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index 13fffe1..e137688 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -2414,9 +2414,8 @@ static void list_slab_objects(struct kmem_cache *s, struct page *page, #ifdef CONFIG_SLUB_DEBUG void *addr = page_address(page); void *p; - long *map = kzalloc(BITS_TO_LONGS(page->objects) * sizeof(long), - GFP_ATOMIC); - + unsigned long *map = kzalloc(BITS_TO_LONGS(page->objects) * + sizeof(long), GFP_ATOMIC); if (!map) return; slab_err(s, page, "%s", text); @@ -3635,7 +3634,7 @@ static int add_location(struct loc_track *t, struct kmem_cache *s, static void process_slab(struct loc_track *t, struct kmem_cache *s, struct page *page, enum track_item alloc, - long *map) + unsigned long *map) { void *addr = page_address(page); void *p; -- 1.7.2.2
|  |