lkml.org 
[lkml]   [2010]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/7] KVM: MMU: cleanup for error mask set while walk guest page table
On 09/27/2010 10:30 PM, Avi Kivity wrote:

>> r = FNAME(walk_addr)(&walker, vcpu, vaddr,
>> - !!(access& PFERR_WRITE_MASK),
>> - !!(access& PFERR_USER_MASK),
>> - !!(access& PFERR_FETCH_MASK));
>> + access& PFERR_WRITE_MASK,
>> + access& PFERR_USER_MASK,
>> + access& PFERR_FETCH_MASK);
>>
>> if (r) {
>> gpa = gfn_to_gpa(walker.gfn);
>
> Interesting. Maybe a next step is to pass the page-fault error code
> instead of the various bits?

Yeah, it's a good idea, i'll post a patch to do it.

> Not sure how that interacts with nested
> ept (which has a different permission model).
>

Umm, we just move the error code parsing from the caller site to FNAME(walk_addr)
function, i think it not make trouble for implement nested ept.


\
 
 \ /
  Last update: 2010-09-28 10:55    [W:0.054 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site