lkml.org 
[lkml]   [2010]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4] power_supply: Add driver for TWL4030/TPS65950 BCI charger
On Tue, Sep 28, 2010 at 03:37:46AM -0500, Grazvydas Ignotas wrote:
>On Tue, Sep 28, 2010 at 9:05 AM, Felipe Balbi <balbi@ti.com> wrote:
>> Hi,
>>
>> On Mon, Sep 27, 2010 at 03:18:24PM -0500, Grazvydas Ignotas wrote:
>>>
>>> +static int twl4030_bci_usb_ncb(struct notifier_block *nb, unsigned long
>>> val,
>>> +                              void *priv)
>>> +{
>>> +       struct twl4030_bci *bci = container_of(nb, struct twl4030_bci,
>>> otg_nb);
>>> +
>>> +       dev_dbg(bci->dev, "OTG notify %lu\n", val);
>>> +
>>> +       switch (val) {
>>> +       case USB_EVENT_VBUS:
>>> +       case USB_EVENT_CHARGER:
>>
>> you should have removed CHARGER from here :-)
>
>hm why? Don't recall you commenting on that, why can't I charge from charger?

Charger event is SENT by charger driver when it verifies it's attached
to a wall charger.

--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2010-09-28 10:45    [from the cache]
©2003-2011 Jasper Spaans