lkml.org 
[lkml]   [2010]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] gainfar.c : skb_over_panic (kernel-2.6.32.15)
From
Hi Eran, David
This bug still exits on current both stable and rc kernel releases
reported on the mail list.
http://lkml.org/lkml/2010/9/28/178
Is there any merge plan this patch to current kernel.
Regards


2010/6/29 Eran Liberty <liberty@extricom.com>:
> David Miller wrote:
>>
>> From: Eran Liberty <liberty@extricom.com>
>> Date: Mon, 28 Jun 2010 10:57:08 +0300
>>
>>
>>>
>>> This code has proved to be insufficient and produce
>>> skb_over_panic. The proposed patch fix this.
>>>
>>
>> Then you have to post a patch relative to the current code, rather than
>> against the code as it was several releases ago.
>>
>> Your patch didn't apply, so I can't use it.
>>
>>
>
> Upon cleaning up my patch for the latest kernel I realized I do not
> like: the previous partial fix, the fix in ucc_geth.c, the fix in the
> current latest kernel, and my own previously proposed patch. They all
> tried to undo the alignment skb_reserve done in gfar_new_skb() before
> queuing the skb into the rw_recycle, because upon getting a new one in
> gfar_new_skb() if the skb is from the rx_recycle pool rather then newly
> allocated it is reserved twice.
>
> Instead of trying to undo the skb_reserve this proposed patch will make
> sure the alignment skb_reserve is done once, upon allocating the skb and
> not when taken out of the rx_recycle pool. Eliminating the need to undo
> anything before queue skb back to the pool.
>
> This patch will apply cleanly against the 2.6.32.15. Another patch will
> be submitted separately for the current Linus tree.
>
> -- Liberty
>
> Signed-off-by: Eran Liberty <liberty@extricom.com>
>
>


\
 
 \ /
  Last update: 2010-09-29 09:51    [from the cache]
©2003-2011 Jasper Spaans