Messages in this thread | | | Date | Tue, 28 Sep 2010 10:14:24 -0700 | From | Jeremy Fitzhardinge <> | Subject | Re: [PATCH 12/12] xen/mtrr: Add mtrr_if support for Xen mtrr |
| |
On 09/28/2010 05:39 AM, Ingo Molnar wrote: > * stefano.stabellini@eu.citrix.com <stefano.stabellini@eu.citrix.com> wrote: > >> From: Stephen Tweedie <sct@redhat.com> >> >> Add a Xen mtrr type, and reorganise mtrr initialisation slightly to >> allow the mtrr driver to set up num_var_ranges (Xen needs to do this by >> querying the hypervisor itself.) >> >> [ Impact: add basic MTRR support ] >> >> Signed-off-by: Stephen Tweedie <sct@redhat.com> >> Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> >> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com> >> --- >> arch/x86/kernel/cpu/mtrr/Makefile | 2 +- >> arch/x86/kernel/cpu/mtrr/main.c | 3 + >> arch/x86/kernel/cpu/mtrr/mtrr.h | 7 ++ >> arch/x86/kernel/cpu/mtrr/xen.c | 110 +++++++++++++++++++++++++++++++++++++ >> 4 files changed, 121 insertions(+), 1 deletions(-) >> create mode 100644 arch/x86/kernel/cpu/mtrr/xen.c > Still NAK, for the very same reasons as we NAK-ed it the previous time: > /proc/mtrr is a problematic and complicated legacy interface that should > die.
Is your objection because we're adding a Xen mtrr implementation at all, or because we're (slightly) extending the mtrr interface to do it?
Thanks, J
| |