lkml.org 
[lkml]   [2010]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 12/12] xen/mtrr: Add mtrr_if support for Xen mtrr

    * stefano.stabellini@eu.citrix.com <stefano.stabellini@eu.citrix.com> wrote:

    > From: Stephen Tweedie <sct@redhat.com>
    >
    > Add a Xen mtrr type, and reorganise mtrr initialisation slightly to
    > allow the mtrr driver to set up num_var_ranges (Xen needs to do this by
    > querying the hypervisor itself.)
    >
    > [ Impact: add basic MTRR support ]
    >
    > Signed-off-by: Stephen Tweedie <sct@redhat.com>
    > Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
    > Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
    > ---
    > arch/x86/kernel/cpu/mtrr/Makefile | 2 +-
    > arch/x86/kernel/cpu/mtrr/main.c | 3 +
    > arch/x86/kernel/cpu/mtrr/mtrr.h | 7 ++
    > arch/x86/kernel/cpu/mtrr/xen.c | 110 +++++++++++++++++++++++++++++++++++++
    > 4 files changed, 121 insertions(+), 1 deletions(-)
    > create mode 100644 arch/x86/kernel/cpu/mtrr/xen.c

    Still NAK, for the very same reasons as we NAK-ed it the previous time:
    /proc/mtrr is a problematic and complicated legacy interface that should
    die. Any modern X server will do the right thing via PAT.

    Also, please get the Ack of at least one x86 maintainer for x86 patches.

    Thanks,

    Ingo


    \
     
     \ /
      Last update: 2010-09-28 14:41    [W:0.026 / U:60.792 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site