lkml.org 
[lkml]   [2010]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2] hwmon (coretemp): Fix build breakage if SMP is undefined
    On Mon, Sep 27, 2010 at 09:02:57AM -0400, Pekka Enberg wrote:
    > On Mon, Sep 27, 2010 at 3:59 PM, Ingo Molnar <mingo@elte.hu> wrote:
    > >
    > > * Guenter Roeck <guenter.roeck@ericsson.com> wrote:
    > >
    > >> +#ifdef CONFIG_SMP
    > >> +#endif
    > >> +#ifdef CONFIG_SMP
    > >> +#endif
    > >
    > > Hm, this tickles my uglo-meter. Is there no cleaner way, preferably one
    > > that doesnt involve preprocessor directives?
    >
    > Implement cpu_sibling_mask() on UP so that the loop goes away?

    So what is the take ? Looks like Linus won't accept my patch without someone
    else signing off on it. If the uglo-meter prevents it from being accepted,
    I'll be happy to submit the SMP cleanup patch instead. As I mentioned
    before, I would prefer that to go into -next.

    Guenter


    \
     
     \ /
      Last update: 2010-09-28 01:33    [W:0.020 / U:1.524 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site