Messages in this thread | | | Date | Mon, 27 Sep 2010 16:27:16 -0700 | From | Guenter Roeck <> | Subject | Re: [PATCH v2] hwmon (coretemp): Fix build breakage if SMP is undefined |
| |
On Mon, Sep 27, 2010 at 09:02:57AM -0400, Pekka Enberg wrote: > On Mon, Sep 27, 2010 at 3:59 PM, Ingo Molnar <mingo@elte.hu> wrote: > > > > * Guenter Roeck <guenter.roeck@ericsson.com> wrote: > > > >> +#ifdef CONFIG_SMP > >> +#endif > >> +#ifdef CONFIG_SMP > >> +#endif > > > > Hm, this tickles my uglo-meter. Is there no cleaner way, preferably one > > that doesnt involve preprocessor directives? > > Implement cpu_sibling_mask() on UP so that the loop goes away?
So what is the take ? Looks like Linus won't accept my patch without someone else signing off on it. If the uglo-meter prevents it from being accepted, I'll be happy to submit the SMP cleanup patch instead. As I mentioned before, I would prefer that to go into -next.
Guenter
| |