[lkml]   [2010]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Subject[PATCHv3 0/3] watchdog: add f71862fg support
    Hi everyone,

    this patch adds support for the watchdog included in Fintek f71862fg
    Super-I/O chip to the f71808e_wdt driver and adds WDIOC_GETTIMELEFT
    ioctl which i found very helpful.

    This patch comes in three parts:
    1/3: add f71862fg support
    2/3: add WDIOC_GETTIMELEFT ioctl and helper function
    3/3: clean up/replace some magic numbers/constants


    * module parameter for WDTRST# pin configuration added
    * checking/printk of WDTRST# pin config
    * removing int typecast

    NOTE: due to an unprobable chain of events (sort of ineffable BOB stuff)
    there wasn't posted more than PATCHv2 0/3 - sorry for the confusion.

    * pin parameter check and pin configuration moved to helper function
    * cleaned up a little more

    Furthermore i was thinking about modifying the WDIOC_GETTIMELEFT
    helper function since it simply returns the content of the WDT timer
    register without regarding whether the driver runs in minute-mode or not
    (thanks to Giel for pointing that out). This means if the driver is loaded
    with a timeout of >255 seconds (and switches to minute-mode) WDIOC_GETTIMELEFT
    ioctl returns minutes instead of seconds and thus doesn't comply with
    watchdog-api (e.g. ioctl returns 6(min) not 360(sec)). It might be
    confusing if one loads the driver with a timeout of let's say 360 seconds
    and gets 6 minutes returned by ioctl. But imho it's not very accurate to
    return a value of seconds if the wdt doesn't count in seconds. That might
    be even more confusing. This inconsistency on the part of the hardware
    maybe can't get satisfyingly compensated by the driver. So i'd prefer the
    most simple solution.


    drivers/watchdog/f71808e_wdt.c | 78 ++++++++++++++++++++++++++++++++++++---
    1 files changed, 72 insertions(+), 6 deletions(-)

    Thanks for help and comments,

    Lutz Ballaschke

     \ /
      Last update: 2010-09-27 20:11    [W:0.220 / U:39.240 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site