lkml.org 
[lkml]   [2010]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    SubjectRe: [PATCH 05/10] Fs: ext4: ext4: cleaned up the file with checkpatch.pl
    Date
    Tracey Dent <tdent48227@gmail.com> writes:

    > --- a/fs/ext4/ext4.h
    > +++ b/fs/ext4/ext4.h
    > @@ -233,8 +233,7 @@ typedef struct ext4_io_end {
    > /*
    > * Structure of a blocks group descriptor
    > */
    > -struct ext4_group_desc
    > -{
    > +struct ext4_group_desc {
    > __le32 bg_block_bitmap_lo; /* Blocks bitmap block */
    > __le32 bg_inode_bitmap_lo; /* Inodes bitmap block */

    Putting a TAB instead of SPACE before the '{' isn't common here, is it?

    > @@ -513,8 +512,8 @@ struct ext4_new_group_data {
    > #define EXT4_IOC_GROUP_EXTEND _IOW('f', 7, unsigned long)
    > #define EXT4_IOC_GROUP_ADD _IOW('f', 8, struct ext4_new_group_input)
    > #define EXT4_IOC_MIGRATE _IO('f', 9)
    > - /* note ioctl 10 reserved for an early version of the FIEMAP ioctl */
    > - /* note ioctl 11 reserved for filesystem-independent FIEMAP ioctl */
    > + /* note ioctl 10 reserved for an early version of the FIEMAP ioctl */
    > + /* note ioctl 11 reserved for filesystem-independent FIEMAP ioctl */
    > #define EXT4_IOC_ALLOC_DA_BLKS _IO('f', 12)

    Doesn't look like an improvement to me.


    > static inline __le32 ext4_encode_extra_time(struct timespec *time)
    > {
    > - return cpu_to_le32((sizeof(time->tv_sec) > 4 ?
    > - (time->tv_sec >> 32) & EXT4_EPOCH_MASK : 0) |
    > - ((time->tv_nsec << EXT4_EPOCH_BITS) & EXT4_NSEC_MASK));
    > + return cpu_to_le32((sizeof(time->tv_sec) > 4 ?
    > + (time->tv_sec >> 32) & EXT4_EPOCH_MASK : 0) |
    > + ((time->tv_nsec << EXT4_EPOCH_BITS) & EXT4_NSEC_MASK));

    Wrong level of indentation.

    > static inline void ext4_decode_extra_time(struct timespec *time, __le32 extra)
    > {
    > - if (sizeof(time->tv_sec) > 4)
    > + if (sizeof(time->tv_sec) > 4)

    Ditto.
    --
    Krzysztof Halasa

    \
     
     \ /
      Last update: 2010-09-27 20:09    [W:0.040 / U:30.552 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site