lkml.org 
[lkml]   [2010]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject2.6.36-rc5+: drivers/hwmon/coretemp.c:506: error: implicit declaration of function 'cpu_sibling_mask'
Date
$ make V=2
CHK include/linux/version.h
CHK include/generated/utsrelease.h
CALL scripts/checksyscalls.sh - due to target is PHONY
CHK include/generated/compile.h
CC [M] drivers/hwmon/coretemp.o - due to target missing
drivers/hwmon/coretemp.c: In function 'coretemp_device_remove':
drivers/hwmon/coretemp.c:506: error: implicit declaration of function 'cpu_sibling_mask'
make[2]: *** [drivers/hwmon/coretemp.o] Error 1
make[1]: *** [drivers/hwmon] Error 2
make: *** [drivers] Error 2

above function is not defined on UP.

This commit introduced the error:

commit e40cc4bdfd4b89813f072f72bd9c7055814d3f0f
Author: Jan Beulich <jbeulich@novell.com>
Date: Mon Sep 13 10:23:05 2010 +0000
x86/hwmon: register alternate sibling upon CPU removal

Just like pkgtemp registers another core of the same package when one
gets removed, coretemp should register another hyperthread (if
available) in that situation.

As pointed out in the patch fixing the respective code in pkgtemp, the
list protectng mutex must be dropped before calling
coretemp_device_add(), and due to the restructured loop (including an
explicit return) the "safe" variant of the list iterator isn't needed
anymore.

Signed-off-by: Jan Beulich <jbeulich@novell.com>
Cc: Rudolf Marek <r.marek@assembler.cz>
Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>


\
 
 \ /
  Last update: 2010-09-27 20:11    [W:0.055 / U:0.492 seconds]
©2003-2014 Jasper Spaans. Advertise on this site