lkml.org 
[lkml]   [2010]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 03/10] hugetlb: redefine hugepage copy functions
    On Thu, Sep 23, 2010 at 11:21:25AM -0500, Christoph Lameter wrote:
    > On Wed, 8 Sep 2010, Naoya Horiguchi wrote:
    >
    > > This patch modifies hugepage copy functions to have only destination
    > > and source hugepages as arguments for later use.
    > > The old ones are renamed from copy_{gigantic,huge}_page() to
    > > copy_user_{gigantic,huge}_page().
    > > This naming convention is consistent with that between copy_highpage()
    > > and copy_user_highpage().
    >
    > Looking at copy_user_highpage(): The vma parameter does not seem to be
    > used anywhere anymore? The vaddr is used on arches that have virtual
    > caching.
    >
    > Maybe removing the vma parameter would allow to simplify the hugetlb
    > code?

    That's right.
    I'll do this cleanup (although it may be aside from this patchset.)

    > Reviewed-by: Christoph Lameter <cl@linux.com>

    Thank you.

    - Naoya Horiguchi


    \
     
     \ /
      Last update: 2010-09-27 20:09    [W:0.021 / U:30.508 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site