lkml.org 
[lkml]   [2010]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH -V4 03/11] vfs: Add a comment to inode_permission()
    Date
    From: Andreas Gruenbacher <agruen@suse.de>

    Signed-off-by: Andreas Gruenbacher <agruen@suse.de>
    Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
    ---
    fs/namei.c | 6 ++++--
    1 files changed, 4 insertions(+), 2 deletions(-)

    diff --git a/fs/namei.c b/fs/namei.c
    index 7cadd07..bf822b8 100644
    --- a/fs/namei.c
    +++ b/fs/namei.c
    @@ -167,7 +167,7 @@ EXPORT_SYMBOL(putname);
    #endif

    /*
    - * This does basic POSIX ACL permission checking
    + * This does the basic permission checking
    */
    static int acl_permission_check(struct inode *inode, int mask,
    int (*check_acl)(struct inode *inode, int mask))
    @@ -212,7 +212,7 @@ int generic_permission(struct inode *inode, int mask,
    int ret;

    /*
    - * Do the basic POSIX ACL permission checks.
    + * Do the basic permission checks.
    */
    ret = acl_permission_check(inode, mask, check_acl);
    if (ret != -EACCES)
    @@ -246,6 +246,8 @@ int generic_permission(struct inode *inode, int mask,
    * We use "fsuid" for this, letting us set arbitrary permissions
    * for filesystem access without changing the "normal" uids which
    * are used for other things.
    + *
    + * When checking for MAY_APPEND, MAY_WRITE must also be set in @mask.
    */
    int inode_permission(struct inode *inode, int mask)
    {
    --
    1.7.0.4


    \
     
     \ /
      Last update: 2010-09-27 20:09    [W:0.044 / U:29.632 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site