lkml.org 
[lkml]   [2010]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[01/80] usb: musb_debugfs: dont use the struct file private_data field with seq_files
    2.6.35-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Mathias Nyman <mathias.nyman@nokia.com>

    commit 024cfa5943a7e89565c60b612d698c2bfb3da66a upstream.

    seq_files use the private_data field of a file struct for storing a seq_file structure,
    data should be stored in seq_file's own private field (e.g. file->private_data->private)
    Otherwise seq_release() will free the private data when the file is closed.

    Signed-off-by: Mathias Nyman <mathias.nyman@nokia.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/usb/musb/musb_debugfs.c | 5 ++---
    1 file changed, 2 insertions(+), 3 deletions(-)

    --- a/drivers/usb/musb/musb_debugfs.c
    +++ b/drivers/usb/musb/musb_debugfs.c
    @@ -195,15 +195,14 @@ static const struct file_operations musb

    static int musb_test_mode_open(struct inode *inode, struct file *file)
    {
    - file->private_data = inode->i_private;
    -
    return single_open(file, musb_test_mode_show, inode->i_private);
    }

    static ssize_t musb_test_mode_write(struct file *file,
    const char __user *ubuf, size_t count, loff_t *ppos)
    {
    - struct musb *musb = file->private_data;
    + struct seq_file *s = file->private_data;
    + struct musb *musb = s->private;
    u8 test = 0;
    char buf[18];




    \
     
     \ /
      Last update: 2010-09-27 20:09    [W:7.185 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site