| | Date | Fri, 24 Sep 2010 09:24:11 -0700 | | From | Greg KH <> | | Subject | [23/80] net/llc: make opt unsigned in llc_ui_setsockopt() |
| |
2.6.35-stable review patch. If anyone has any objections, please let us know.
------------------ From: Dan Carpenter <error27@gmail.com>
commit 339db11b219f36cf7da61b390992d95bb6b7ba2e upstream.
The members of struct llc_sock are unsigned so if we pass a negative value for "opt" it can cause a sign bug. Also it can cause an integer overflow when we multiply "opt * HZ".
Signed-off-by: Dan Carpenter <error27@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
--- net/llc/af_llc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/net/llc/af_llc.c +++ b/net/llc/af_llc.c @@ -1024,7 +1024,8 @@ static int llc_ui_setsockopt(struct sock { struct sock *sk = sock->sk; struct llc_sock *llc = llc_sk(sk); - int rc = -EINVAL, opt; + unsigned int opt; + int rc = -EINVAL; lock_sock(sk); if (unlikely(level != SOL_LLC || optlen != sizeof(int)))
|