[lkml]   [2010]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] x86/mrst: add SFI platform device parsing code
> So the expectation is that the platform data parser functions in the
> SFI device list will be querying the DMI data and selecting the actual
> parsing based on that? Perhaps adding DMI keys to the match tables so
> the infrastructure is there for doing the device specific things would
> cover it; minor differences could be worked out in the default match
> function and we can drop back to board specific functions when it gets
> too messy.

That will just encourage people not to be careful.

> My main issue here is that the code is working on the assumption that
> we have one standard idea of what the SFI data means and provides no
> guidance to users about handling the inevitable variations.

There should be no variations and the nature of the platform means that
might even work out. I don't really want to add it to the table unless
we have lots needing DMI data. Right now we don't and there are
multiple platform implementations in existence.


 \ /
  Last update: 2010-09-27 20:09    [W:0.093 / U:0.076 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site