lkml.org 
[lkml]   [2010]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3] led-class: always implement blinking
    On Wed, 22 Sep 2010 15:53:58 +0200
    Johannes Berg <johannes@sipsolutions.net> wrote:

    > Currently, blinking LEDs can be awkward because it is
    > not guaranteed that all LEDs implement blinking. The
    > trigger that wants it to blink then needs to implement
    > its own timer solution.
    >
    > Rather than require that, add led_blink_set() API that
    > triggers can use. This function will attempt to use hw
    > blinking, but if that fails implements a timer for it.
    > To stop blinking again, brightness_set() also needs to
    > be wrapped into API that will stop the software blink.
    >
    > As a result of this, the timer trigger becomes a very
    > trivial one, and hopefully we can finally see triggers
    > using blinking as well because it's always easy to use.
    >
    > Signed-off-by: Johannes Berg <johannes.berg@intel.com>
    > ---
    > v2: - update documentation
    > - use documented way of turning blinking off
    > by setting brightness to 0 rather than by
    > setting delays to (0, 0)
    > - add API to start blinking, set brightness
    > (the latter will also stop sw blinking)
    > v3: - make LEDS_CLASS a bool rather than tristate
    > because LEDS_TRIGGERS now depends on symbols
    > it exports

    `make oldconfig' says

    boolean symbol LEDS_CLASS tested for 'm'? test forced to 'n'


    \
     
     \ /
      Last update: 2010-09-27 20:09    [W:0.049 / U:1.000 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site