lkml.org 
[lkml]   [2010]   [Sep]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/5] Staging: rtl8187se: r8180.h: fixed alot of checkpatch.pl issues
On 21:19 Mon 20 Sep     , Tracey Dent wrote:
> Fixed numerous coding style issues
>
The subject should be more specific as to what the patch does, such as
"Staging: rtl8187se: r8180.h: whitespace cleanup."

And the explanation in the commit should also be more specific. There are
plenty of examples if you look through the log. Greg might except them as is,
but any future patches should follow the advice mentioned. Next time for a
patch of this nature remember to CC kernel-janitors too.

Thanks,
mfm


\
 
 \ /
  Last update: 2010-09-23 01:29    [W:1.800 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site