Messages in this thread | | | Date | Wed, 22 Sep 2010 16:24:58 -0700 | From | matt mooney <> | Subject | Re: [PATCH 1/5] Staging: rtl8187se: r8180.h: fixed alot of checkpatch.pl issues |
| |
On 21:19 Mon 20 Sep , Tracey Dent wrote: > Fixed numerous coding style issues > The subject should be more specific as to what the patch does, such as "Staging: rtl8187se: r8180.h: whitespace cleanup."
And the explanation in the commit should also be more specific. There are plenty of examples if you look through the log. Greg might except them as is, but any future patches should follow the advice mentioned. Next time for a patch of this nature remember to CC kernel-janitors too.
Thanks, mfm
| |