Messages in this thread |  | | | Date | Wed, 22 Sep 2010 11:02:50 -0400 | | From | Mathieu Desnoyers <> | | Subject | Re: [PATCH 2/2] Rewrite jump_label.c to use binary search |
| |
* Andi Kleen (andi@firstfloor.org) wrote: > > > > >>> + for (; entry < stop && entry->key == key; entry++) > >>> + if (kernel_text_address(entry->code)) > >> > >> This does not work for modules I'm afraid, only for the core kernel. You > >> should test for __module_text_address() somewhere. > > > > I thought it was shared now, but ok. > > Double checked. This is ok because kernel_text_address() > already checks for modules. You were probably thinking > of __kernel_text_address()
Ah right,
Although we have another problem:
__module_text_address() includes module init text, which defeats the purpose of the check put in there by Jason.
So the check works for the core kernel, but not for modules.
Mathieu
> > -Andi >
-- Mathieu Desnoyers Operating System Efficiency R&D Consultant EfficiOS Inc. http://www.efficios.com
|  |