lkml.org 
[lkml]   [2010]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] FW_LOADER: fix kconfig dependency warning on HOTPLUG
On Tue, Sep 21, 2010 at 03:45:49PM -0700, Randy Dunlap wrote:
> On 09/21/10 15:25, Greg KH wrote:
> > On Sat, Sep 18, 2010 at 01:23:08PM -0700, Randy Dunlap wrote:
> >>
> >> BTW, drivers/base/firmware_class.c should #include <linux/kobject.h>.
> >
> > Why, it looks like it builds properly now, right?
>
> Yes, it builds because (apparently) some other header file is causing
> <linux/kobject.h> to be sucked in. That's not how we prefer to have header
> files used.
>
> See Documentation/SubmitChecklist, item #1 (from Stephen Rothwell):
>
> 1: If you use a facility then #include the file that defines/declares
> that facility. Don't depend on other header files pulling in ones
> that you use.

Fair enough, care to send a patch? :)

thanks,

greg k-h


\
 
 \ /
  Last update: 2010-09-22 00:53    [from the cache]
©2003-2011 Jasper Spaans