[lkml]   [2010]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] FW_LOADER: fix kconfig dependency warning on HOTPLUG
On 09/21/10 15:25, Greg KH wrote:
> On Sat, Sep 18, 2010 at 01:23:08PM -0700, Randy Dunlap wrote:
>> BTW, drivers/base/firmware_class.c should #include <linux/kobject.h>.
> Why, it looks like it builds properly now, right?

Yes, it builds because (apparently) some other header file is causing
<linux/kobject.h> to be sucked in. That's not how we prefer to have header
files used.

See Documentation/SubmitChecklist, item #1 (from Stephen Rothwell):

1: If you use a facility then #include the file that defines/declares
that facility. Don't depend on other header files pulling in ones
that you use.

*** Remember to use Documentation/SubmitChecklist when testing your code ***

 \ /
  Last update: 2010-09-22 00:49    [W:0.038 / U:0.732 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site