Messages in this thread | | | From | Timur Tabi <> | Date | Tue, 21 Sep 2010 17:04:39 -0500 | Subject | Re: [PATCH] fsldma: add support to 36-bit physical address |
| |
On Tue, Sep 21, 2010 at 4:49 PM, Scott Wood <scottwood@freescale.com> wrote:
> Look in dmaengine.c, there are calls to dma_map_single() and > dma_map_page(), using what I assume is that same device pointer -- > unless there's confusion between the channel and the controller.
You're right. I missed this line in the driver:
fdev->common.dev = &op->dev;
Also, the driver does something stupid. Sometimes "chan->dev" refers to dma_chan.chan, and sometimes it refers to fsldma_chan.chan. I could have sworn I saw a patch that fixes that, though.
-- Timur Tabi Linux kernel developer at Freescale
| |