lkml.org 
[lkml]   [2010]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] fsldma: add support to 36-bit physical address
On Tue, Sep 21, 2010 at 4:49 PM, Scott Wood <scottwood@freescale.com> wrote:

> Look in dmaengine.c, there are calls to dma_map_single() and
> dma_map_page(), using what I assume is that same device pointer --
> unless there's confusion between the channel and the controller.

You're right. I missed this line in the driver:

fdev->common.dev = &op->dev;

Also, the driver does something stupid. Sometimes "chan->dev" refers
to dma_chan.chan, and sometimes it refers to fsldma_chan.chan. I
could have sworn I saw a patch that fixes that, though.

--
Timur Tabi
Linux kernel developer at Freescale


\
 
 \ /
  Last update: 2010-09-22 00:07    [W:0.050 / U:0.504 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site