lkml.org 
[lkml]   [2010]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 4/5] uio: Support 2^MINOR_BITS minors
    On Fri, Sep 17, 2010 at 10:36:50PM +0200, Thomas Gleixner wrote:
    > On Tue, 14 Sep 2010, Eric W. Biederman wrote:
    >
    > >
    > > register_chrdev limits uio devices to 256 minor numbers which causes
    > > problems on one system I have with 384+ uio devices. So instead set
    > > UIO_MAX_DEVICES to the maximum number of minors and use
    > > alloc_chrdev_region to reserve the uio minors.
    > >
    > > The final result is that the code works the same but the uio driver now
    > > supports any minor the idr allocator comes up with.
    > >
    > > Signed-off-by: Eric W. Biederman <ebiederm@aristanetworks.com>
    >
    > One minor nit:
    >
    > > + result = alloc_chrdev_region(&uio_dev, 0, UIO_MAX_DEVICES, name);
    > > + if (result)
    > > + goto out;
    >
    > return result;

    Wait, why? It's the exact came code, as out does:

    out:
    return result;

    and you need that line due to the code above it. So I say leave it.

    thanks,

    greg k-h


    \
     
     \ /
      Last update: 2010-09-21 23:25    [W:0.030 / U:0.164 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site