lkml.org 
[lkml]   [2010]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC] led-class: always implement blinking
    On Fri, 20 Aug 2010 11:21:42 +0200
    Johannes Berg <johannes@sipsolutions.net> wrote:

    > +static int led_blink_set(struct led_classdev *led_cdev,
    > + unsigned long *delay_on, unsigned long *delay_off)
    > +{
    > + int current_brightness;
    > +
    > + current_brightness = led_get_brightness(led_cdev);
    > + if (current_brightness)
    > + led_cdev->blink_brightness = current_brightness;
    > + if (!led_cdev->blink_brightness)
    > + led_cdev->blink_brightness = led_cdev->max_brightness;
    > +
    > + if (*delay_on == led_cdev->blink_delay_on &&
    > + *delay_off == led_cdev->blink_delay_off)
    > + return 0;
    > +
    > + /* deactivate previous settings */
    > + del_timer_sync(&led_cdev->blink_timer);
    > +
    > + led_cdev->blink_delay_on = *delay_on;
    > + led_cdev->blink_delay_off = *delay_off;
    > +
    > + /* never on - don't blink */
    > + if (!*delay_on)
    > + return 0;
    > +
    > + /* never off - just set to brightness */
    > + if (!*delay_off) {
    > + led_set_brightness(led_cdev, led_cdev->blink_brightness);
    > + return 0;
    > + }
    > +
    > + mod_timer(&led_cdev->blink_timer, jiffies + 1);
    > +
    > + return 0;
    > +}

    delay_on and delay_off could have been pass-by-value rather than
    pass-by-reference? That would clean up some gunk in callers, too.

    If there was some reason for doing it with pass-by-reference then that
    reason should have been documented!


    \
     
     \ /
      Last update: 2010-09-21 21:47    [W:2.515 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site