Messages in this thread | | | Date | Tue, 21 Sep 2010 12:26:38 -0700 | From | Frank Rowand <> | Subject | Re: [PATCH 3/4] tracing/sched: Add sched_rt_push and sched_rt_pull tracepoints |
| |
On 09/21/10 06:36, Steven Rostedt wrote: > On Tue, 2010-09-21 at 08:33 -0400, Steven Rostedt wrote: > >>> Why doesn't the migration tracepoint cover this? It shows you the task, >>> the prio, the old and new cpu. If the migration is logged from the old >>> cpu, its a push, if its logged from the new its a pull, no?
Slight nuance...
If the migration is logged from a cpu other than the new cpu, it is a push.
>> >> For some reason it did not help me enough in my analysis. I'll go back >> and see why. >> >> I originally had these tracepoints at the front of the series, and >> realized they may be a little controversial, thus I moved them to the >> end. > > OK, I went back and looked, and I think you are right. I can determine > this from the migration tracepoint. I think I was just being lazy and > wanted to have the direction obvious to me :-) I can easily do that by > adding a plugin. > > Anyway, I'll remove this patch and rename the sched_rt_setprio > tracepoint to sched_pi_setprio. Would that be OK with you? > > Thanks, > > -- Steve
Regards,
Frank
| |