lkml.org 
[lkml]   [2010]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 03/10] hugetlb: redefine hugepage copy functions
    From

    >> +static void copy_gigantic_page(struct page *dst, struct page *src)
    >> +{
    >> + int i;
    >> + struct hstate *h = page_hstate(src);
    >> + struct page *dst_base = dst;
    >> + struct page *src_base = src;
    >> +
    >> + for (i = 0; i < pages_per_huge_page(h); ) {
    >> + cond_resched();
    >
    > Should this function not have a might_sleep() check too?

    cond_resched() implies might_sleep I believe. I think
    that answers the earlier question too becuse that function
    calls this.

    /*
    >
    > Other than the removal of the might_sleep() check, this looks ok too.

    Can I assume an Ack?

    Thanks,
    -Andi



    \
     
     \ /
      Last update: 2010-09-20 13:19    [W:0.025 / U:0.508 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site