[lkml]   [2010]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 0/10] Hugepage migration (v5)
    On Thu, Sep 09, 2010 at 12:33:06PM +0200, Andi Kleen wrote:
    > On Wed, 8 Sep 2010 10:19:31 +0900
    > Naoya Horiguchi <> wrote:
    > > Hi,
    > >
    > > This is the 5th version of "hugepage migration" set.
    > >
    > > Changes from v4 (mostly refactoring):
    > > - remove unnecessary might_sleep() [3/10]
    > > - define migrate_huge_pages() from copy of migrate_pages() [4/10]
    > > - soft_offline_page() branches off to hugepage path. [8/10]
    > I went over this patchkit again and it all looks good to me.
    > I plan to merge it through my hwpoison tree.
    > As far as I understand all earlier comments have been addressed
    > with this revision, correct?
    > Thanks for your work, this is very good.
    > But I would like to have some Acks from Christoph for the
    > page migration changes and from Mel for the hugetlb changes
    > outside memory-failures.c. Are the patches ok for you two?
    > Can I have your Acked-by or Reviewed-by?

    Sorry for taking so long to get back. I was snowed under by other work.
    I've reviewed the bulk of the hugetlb changes that affect common paths.
    There are a few small queries there but they are very minor. Once covered,
    feel free to add by Acked-by. I didn't get the chance to actually test the
    patches but they look ok.

    > Any other comments would be welcome too.
    > I am considering to fast track 10/10 (the page-types fix).
    > I think the other bug fixes in the series are only for bugs added
    > earlier in the series, correct?

    That is what it looked like to me.

    Mel Gorman
    Part-time Phd Student Linux Technology Center
    University of Limerick IBM Dublin Software Lab

     \ /
      Last update: 2010-09-20 13:17    [W:0.020 / U:2.596 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site