Messages in this thread | | | Date | Mon, 20 Sep 2010 09:31:07 +0100 | From | Alan Cox <> | Subject | Re: [PATCH 0/3] Fix the TIOCGICOUNT problem for good |
| |
On Sat, 18 Sep 2010 11:58:20 -0400 Christoph Hellwig <hch@infradead.org> wrote:
> On Thu, Sep 16, 2010 at 06:21:06PM +0100, Alan Cox wrote: > > Remembering to clear fields is something driver authors are simply > > never going to remember to get right every new driver. Instead take > > the problem away from them and give them a simple interface to do > > the job. > > Btw, I wonder if all the standard tty ioctls should get similar > treatment. That way we have a nice enough skeleton of what needs to > be implemented in every tty driver instead of passing down the raw > ioctl method.
They have pretty much entirely now - TIOCMIWAIT is the main one that hasn't been done, but that really wants a generic implementation in tty_port that most drivers could then use.
Alan
| |