lkml.org 
[lkml]   [2010]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFCv2][PATCH] add some drop_caches documentation and info messsge
On Thu, 16 Sep 2010 09:50:47 -0700
Dave Hansen <dave@linux.vnet.ibm.com> wrote:

>
> This version tones down the BUG_ON(). I also noticed that the
> documentation fails to mention that more than just the inode
> and dentry slabs are shrunk.
>
> --
>
> There is plenty of anecdotal evidence and a load of blog posts
> suggesting that using "drop_caches" periodically keeps your system
> running in "tip top shape". Perhaps adding some kernel
> documentation will increase the amount of accurate data on its use.
>
> If we are not shrinking caches effectively, then we have real bugs.
> Using drop_caches will simply mask the bugs and make them harder
> to find, but certainly does not fix them, nor is it an appropriate
> "workaround" to limit the size of the caches.
>
> It's a great debugging tool, and is really handy for doing things
> like repeatable benchmark runs. So, add a bit more documentation
> about it, and add a little KERN_NOTICE. It should help developers
> who are chasing down reclaim-related bugs.
>
> Signed-off-by: Dave Hansen <dave@linux.vnet.ibm.com>

Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>

thanks.



\
 
 \ /
  Last update: 2010-09-21 03:07    [W:0.048 / U:0.348 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site