Messages in this thread |  | | | Date | Mon, 20 Sep 2010 10:27:37 +0200 | | Subject | Re: [Patch, RFC] Make struct fb_info ref-counted with kref | | From | Geert Uytterhoeven <> |
| |
On Sun, Sep 19, 2010 at 18:47, Florian Tobias Schandinat <FlorianSchandinat@gmx.de> wrote: > Bruno Prémont schrieb: >> diff --git a/drivers/video/fbsysfs.c b/drivers/video/fbsysfs.c >> index 0a08f13..be5f342 100644 >> --- a/drivers/video/fbsysfs.c >> +++ b/drivers/video/fbsysfs.c >> @@ -58,6 +58,7 @@ struct fb_info *framebuffer_alloc(size_t size, struct >> device *dev) >> info->par = p + fb_info_size; >> info->device = dev; >> + kref_init(&info->refcount); > > As far as I know there exist framebuffer drivers which do not call > framebuffer_alloc but contain their own fb_info. I guess these would be > broken as well.
Those should be converted to framebuffer_alloc() anyway. Janitors?
Gr{oetje,eeting}s, Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |