Messages in this thread | | | Date | Mon, 20 Sep 2010 14:59:29 +0200 | From | Borislav Petkov <> | Subject | Re: [RFC 3/6] x86, NMI, Rename memory parity error to PCI SERR error |
| |
From: Robert Richter <robert.richter@amd.com> Date: Mon, Sep 20, 2010 at 10:00:10AM +0200
(adding Doug to CC)
> On 18.09.10 20:20:35, Huang Ying wrote: > > > If I am not wrong the only real functional change is to rip out the > > > edac handler. So, just introduce the final names with your renaming in > > > patch #1 (and maybe make a comment in the commit message or change > > > patch order). > > > > If I merge the 1/6 and 3/6, can you suggest a patch subject, "Add symbol > > definition for NMI magic constants and rename memory parity to PCI > > SERR"? > > Yes, maybe we make the edac change a separate one.
What is more, there are a bunch of edac drivers using the PCI SERR nmi as a means to check for PCI errors so we shouldn't be removing it now, should we?
-- Regards/Gruss, Boris.
Operating Systems Research Center Advanced Micro Devices, Inc.
| |