lkml.org 
[lkml]   [2010]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 05/12] viafb: fix i2c_transfer error handling
On Sun, 19 Sep 2010 07:33:46 +0000
Florian Tobias Schandinat <FlorianSchandinat@gmx.de> wrote:

> i2c_transfer returns negative errno on error and number of messages
> processed on success. Just returning this value would give a poor
> interface as it is not obvious that you must compare with 2 after reading
> 1 or n bytes and with 1 after writing 1 byte to determine if it was
> successful. To avoid this error prone interface convert the error code
> of a successful read/write to zero and all other non-negative values to
> an negative error code.
> This fixes a regression introduced by
> via: Rationalize vt1636 detection
> which resulted in no longer detecting a VT1636 chip and therefore has
> broken the output in configurations wich contain this chip.

From a quick look, all of these patches look like improvements to me.
This one, since it's a regression fix, should probably have a
Cc: stable@kernel.org in it as well.

Acked-by: Jonathan Corbet <corbet@lwn.net>

jon


\
 
 \ /
  Last update: 2010-09-20 14:47    [W:0.069 / U:0.516 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site