lkml.org 
[lkml]   [2010]   [Sep]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 07/24] ptrace: cleanup arch_ptrace() and friends on Blackfin
    Date
    Change signature of get/put_reg() according to the change of arch_ptrace()
    and remove unnecessary castings.

    Signed-off-by: Namhyung Kim <namhyung@gmail.com>
    Cc: Mike Frysinger <vapier@gentoo.org>
    ---
    arch/blackfin/kernel/ptrace.c | 13 +++++++------
    1 files changed, 7 insertions(+), 6 deletions(-)

    diff --git a/arch/blackfin/kernel/ptrace.c b/arch/blackfin/kernel/ptrace.c
    index fb81620..545fc14 100644
    --- a/arch/blackfin/kernel/ptrace.c
    +++ b/arch/blackfin/kernel/ptrace.c
    @@ -37,12 +37,13 @@
    * Get contents of register REGNO in task TASK.
    */
    static inline long
    -get_reg(struct task_struct *task, long regno, unsigned long __user *datap)
    +get_reg(struct task_struct *task, unsigned long regno,
    + unsigned long __user *datap)
    {
    long tmp;
    struct pt_regs *regs = task_pt_regs(task);

    - if (regno & 3 || regno > PT_LAST_PSEUDO || regno < 0)
    + if (regno & 3 || regno > PT_LAST_PSEUDO)
    return -EIO;

    switch (regno) {
    @@ -73,11 +74,11 @@ get_reg(struct task_struct *task, long regno, unsigned long __user *datap)
    * Write contents of register REGNO in task TASK.
    */
    static inline int
    -put_reg(struct task_struct *task, long regno, unsigned long data)
    +put_reg(struct task_struct *task, unsigned long regno, unsigned long data)
    {
    struct pt_regs *regs = task_pt_regs(task);

    - if (regno & 3 || regno > PT_LAST_PSEUDO || regno < 0)
    + if (regno & 3 || regno > PT_LAST_PSEUDO)
    return -EIO;

    switch (regno) {
    @@ -361,14 +362,14 @@ long arch_ptrace(struct task_struct *child, long request,
    return copy_regset_to_user(child, &user_bfin_native_view,
    REGSET_GENERAL,
    0, sizeof(struct pt_regs),
    - (void __user *)data);
    + datap);

    case PTRACE_SETREGS:
    pr_debug("ptrace: PTRACE_SETREGS\n");
    return copy_regset_from_user(child, &user_bfin_native_view,
    REGSET_GENERAL,
    0, sizeof(struct pt_regs),
    - (const void __user *)data);
    + datap);

    case_default:
    default:
    --
    1.7.2.2


    \
     
     \ /
      Last update: 2010-09-02 17:51    [W:0.103 / U:60.784 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site