Messages in this thread | | | Subject | Re: [PATCH] Add quick erase format option | From | Stefani Seibold <> | Date | Thu, 02 Sep 2010 13:42:43 +0200 |
| |
Am Donnerstag, den 02.09.2010, 13:58 +0300 schrieb Artem Bityutskiy: > On Thu, 2010-09-02 at 08:53 +0200, Stefani Seibold wrote: > > --do-not-use-me is the best. But more seriously i think we should it > > split it into two options. --all-erased and --check-erased. The first > > assumes that all PEB are erased, while the second do the check if the > > PEB is erased and if not it will be erased. > > > > So we can handle NAND's, which have a fast erase, and NOR's which are > > very slow. With this we are able to pick the best option for the > > manufacturing. > > I am fine with checking, but what bothers me is that you check only 64 > bytes out of 128KiB - why this is enough to make sure the eraseblock is > erased? > > Probably it is ok for you, but in for general use-case this is wrong, > even checking all 128KiB is wrong, because of the unstable bits. > > What I think will make more sense is to add general option --verify or > something like that. It would read everything the utility wrote and > verify it is identical to what was written. Probably this can be done in > libmtd. > > Then you will be able to combine --all-erased with --verify and achieve > what you want. >
Agree. I will create a patch for this in the next few days.
- Stefani
| |