lkml.org 
[lkml]   [2010]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH RFC] kvm: enable irq injection from interrupt context
    On Sun, Sep 19, 2010 at 12:55:12PM +0200, Michael S. Tsirkin wrote:
    > On Sun, Sep 19, 2010 at 12:56:12PM +0200, Avi Kivity wrote:
    > > On 09/19/2010 12:45 PM, Michael S. Tsirkin wrote:
    > > >On Fri, Sep 17, 2010 at 09:59:29AM +0200, Gleb Natapov wrote:
    > > >> > writing 0 to eventfd does nothing. The way to deassert irq
    > > >> That is implementation detail of current irqfd. It was designed for MSI
    > > >> not level triggered interrupts.
    > > >
    > > >Maybe we should add a check that gsi is mapped to MSI (or unmapped) then?
    > > >Level which switches to 1 and back to 0 immediately will be racy anyway
    > > >...
    > > >
    > >
    > > Add a check where?
    >
    > I would make sure that if you bind irqfd to a non-MSI GSI,
    > signalling it has no effect.
    >
    Why would you do that? I am not against checking per se, but why a user of
    the API can't check for that?

    --
    Gleb.


    \
     
     \ /
      Last update: 2010-09-19 13:21    [from the cache]
    ©2003-2011 Jasper Spaans