lkml.org 
[lkml]   [2010]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 0/17]: New SCSI target framework (SCST) with dev handlers and 2 target drivers
    From
    On Wed, Sep 15, 2010 at 7:56 AM, Dmitry Torokhov
    <dmitry.torokhov@gmail.com> wrote:
    >
    > Hi Vladislav,
    >
    > On Tue, Sep 14, 2010 at 06:36:30PM +0400, Vladislav Bolkhovitin wrote:
    > > Hi All,
    > >
    > > Please review this second iteration of the patch set of the new
    > > (although, perhaps, the oldest) SCSI target framework for Linux SCST
    > > with a set of dev handlers and 2 target drivers: for local access
    > > (scst_local) and for Infiniband SRP (srpt).
    > >
    >
    > [ ... ]
    >
    > And too many "naked returns", I believe common style is to only have
    > return for non-void functions.

    Hello Dmitry,

    If there is agreement among kernel maintainers that return statements
    at the end of functions that do not return a value should be avoided,
    it might be a good idea to let checkpatch complain about such return
    statements. Currently checkpatch doesn't complain about such return
    statements.

    Bart.


    \
     
     \ /
      Last update: 2010-09-19 11:57    [W:0.019 / U:1.928 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site