lkml.org 
[lkml]   [2010]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] hid: 3m: Output proper orientation range
On Sun, Sep 19, 2010 at 10:56:23AM +0200, Henrik Rydberg wrote:
> The range of orientation values for height/width devices should
> be [0, 1], but is currently set to [1, 1]. Having min == max also
> breaks uinput device setup. Fixed with this patch.
>
> Signed-off-by: Henrik Rydberg <rydberg@euromail.se>

Makes sense.

Acked-by: Dmitry Torokhov <dtor@mail.ru>

> ---
> drivers/hid/hid-3m-pct.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/hid/hid-3m-pct.c b/drivers/hid/hid-3m-pct.c
> index cd4b125..860d47c 100644
> --- a/drivers/hid/hid-3m-pct.c
> +++ b/drivers/hid/hid-3m-pct.c
> @@ -110,7 +110,7 @@ static int mmm_input_mapping(struct hid_device *hdev, struct hid_input *hi,
> input_set_abs_params(hi->input, ABS_MT_TOUCH_MINOR,
> f1, f2, df / SN_WIDTH, 0);
> input_set_abs_params(hi->input, ABS_MT_ORIENTATION,
> - 1, 1, 0, 0);
> + 0, 1, 0, 0);
> return 1;
> case HID_DG_CONTACTID:
> field->logical_maximum = MAX_TRKID;
> --
> 1.7.1
>

--
Dmitry


\
 
 \ /
  Last update: 2010-09-20 01:27    [W:0.075 / U:2.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site