Messages in this thread Patch in this message | | | From | Namhyung Kim <> | Subject | [PATCH 3/4] printk: Change type of 'boot_delay' to int * | Date | Sun, 19 Sep 2010 00:53:01 +0900 |
| |
get_option() takes its 2nd arg as int * so passing boot_delay to it caused following warnings from sparse:
kernel/printk.c:223:27: warning: incorrect type in argument 2 (different signedness) kernel/printk.c:223:27: expected int *pint kernel/printk.c:223:27: got unsigned int static [toplevel] *<noident>
Since boot_delay can't grow more than 10,000 changing it to 'int *' will not produce any problem.
Signed-off-by: Namhyung Kim <namhyung@gmail.com> --- kernel/printk.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/printk.c b/kernel/printk.c index a7aa858..e5a5c13 100644 --- a/kernel/printk.c +++ b/kernel/printk.c @@ -210,7 +210,7 @@ __setup("log_buf_len=", log_buf_len_setup); #ifdef CONFIG_BOOT_PRINTK_DELAY -static unsigned int boot_delay; /* msecs delay after each printk during bootup */ +static int boot_delay; /* msecs delay after each printk during bootup */ static unsigned long long loops_per_msec; /* based on boot_delay */ static int __init boot_delay_setup(char *str) -- 1.7.0.4
| |