Messages in this thread | | | Subject | Re: [RFC 3/6] x86, NMI, Rename memory parity error to PCI SERR error | From | Huang Ying <> | Date | Sun, 19 Sep 2010 08:20:35 +0800 |
| |
On Fri, 2010-09-17 at 17:14 +0800, Robert Richter wrote: > On 16.09.10 20:08:25, Huang Ying wrote: > > On Thu, 2010-09-16 at 16:18 +0800, Robert Richter wrote: > > > On 12.09.10 22:02:06, Huang Ying wrote: > > > > > Haven't you introduced *_MEMPAR with patch 1/6? > > > > > > > > Yes. And I suggest to rename it to *_SERR in this patch to reflect the > > > > contemporary hardware better. I think they are two steps: naming the > > > > magic number and changing the name of constant and function. > > > > > > Hmm, I would rather avoid introducing a name and then immediatly > > > renaming it again. > > > > I split them into two patches because there is function named as > > mem_parity_error already. The 1/6 names constants as *_MEMPAR to make it > > consistent with mem_parity_error(). 3/6 rename both the constants, > > function name and some string/comments to serr. Do you think this is > > more clean? > > If I am not wrong the only real functional change is to rip out the > edac handler. So, just introduce the final names with your renaming in > patch #1 (and maybe make a comment in the commit message or change > patch order).
If I merge the 1/6 and 3/6, can you suggest a patch subject, "Add symbol definition for NMI magic constants and rename memory parity to PCI SERR"?
Best Regards, Huang Ying
| |