Messages in this thread | | | Date | Sat, 18 Sep 2010 23:54:47 +0100 | From | Ralf Baechle <> | Subject | Re: [PATCH 01/25] arch/mips: Use static const char arrays |
| |
On Mon, Sep 13, 2010 at 12:47:39PM -0700, Joe Perches wrote:
> diff --git a/arch/mips/pnx8550/common/reset.c b/arch/mips/pnx8550/common/reset.c > index fadd874..e0ac0b2 100644 > --- a/arch/mips/pnx8550/common/reset.c > +++ b/arch/mips/pnx8550/common/reset.c > @@ -27,8 +27,8 @@ > > void pnx8550_machine_restart(char *command) > { > - char head[] = "************* Machine restart *************"; > - char foot[] = "*******************************************"; > + static const char head[] = "************* Machine restart *************"; > + static const char foot[] = "*******************************************"; > > printk("\n\n"); > printk("%s\n", head);
NAK.
The printks should have been taken out and shot. And while at it line use the space on the other side of the wall for pnx8550_machine_power_off.
Ralf
| |