Messages in this thread | | | Date | Fri, 17 Sep 2010 10:13:58 +0200 | From | Robert Richter <> | Subject | Re: [PATCH] x86: fix duplicate calls of the nmi handler |
| |
On 17.09.10 03:52:16, Peter Zijlstra wrote: > On Fri, 2010-09-17 at 08:13 +0800, Huang Ying wrote: > > > Please take a look at my recent patch that rewrites the NMI handler. > > (Link would have been useful) > > > Where NMI are divided into two types. CPU specific NMI are processed > > firstly as DIE_NMI_IPI, and non-CPU specific NMI are processed as > > DIE_NMI. > > OK, and you can discriminate between these two by means of that reason > port? Still I think NMI_IPI is a terrible name for that.
I think the current implementation that devides into NMI and NMI_IPI is just to keep a certain order when calling the handlers - handling local NMIs before non-CPU NMIs.
The patch I send is wrong, it should actually remove DIE_NMI_IPI. But in the end the result is the same, not to call the perf handler twice.
I had this in my patch queue and posted it for debugging the 'unknown nmi' warnings. Huang also did the same change in his patch set, but his patch included too much changes and was not usable as a single fix.
I am fine with dropping this patch in favor of Huang's patches, but maybe we extract a single patch of this change for stable too.
-Robert
-- Advanced Micro Devices, Inc. Operating System Research Center
| |