Messages in this thread | | | Date | Thu, 16 Sep 2010 23:53:05 -0700 (PDT) | Subject | Re: [Security] [PATCH v4] drivers/net/tulip/de4x5.c: fix union member name in DE4X5_GET_REG ioctl | From | David Miller <> |
| |
From: Willy Tarreau <w@1wt.eu> Date: Fri, 17 Sep 2010 08:36:02 +0200
> On Thu, Sep 16, 2010 at 10:34:41PM -0700, David Miller wrote: >> From: Dan Rosenberg <drosenberg@vsecurity.com> >> Date: Fri, 17 Sep 2010 01:30:36 -0400 >> >> > Tiring doesn't begin to describe it. Formatting undamaged. >> >> :-) Thanks. >> >> > This was previously reported as a security issue due to leakage of >> > uninitialized stack memory. Jeff Mahoney pointed out that this is >> > incorrect since the copied data is from a union (rather than a struct). >> > Therefore, this patch is only under consideration for the sake of >> > correctness, and is not security relevant. >> > >> > Signed-off-by: Dan Rosenberg <dan.j.rosenberg@gmail.com> >> > Acked-by: Grant Grundler <grundler@parisc-linux.org> >> >> Applied. > > David, just for the record, as was already reported on the list, this > fix is finally more a cleanup than a security fix because "tmp" is a > union and not a struct, so tmp.addr == tmp.lval.
I can read, thanks :-)
That's why I applied it to net-next-2.6 and not net-2.6
| |