Messages in this thread | | | Date | Fri, 17 Sep 2010 08:37:54 +0200 | From | Willy Tarreau <> | Subject | Re: [Security] [PATCH v4] drivers/net/tulip/de4x5.c: fix union member name in DE4X5_GET_REG ioctl |
| |
On Fri, Sep 17, 2010 at 08:36:02AM +0200, Willy Tarreau wrote: > On Thu, Sep 16, 2010 at 10:34:41PM -0700, David Miller wrote: > > From: Dan Rosenberg <drosenberg@vsecurity.com> > > Date: Fri, 17 Sep 2010 01:30:36 -0400 > > > > > Tiring doesn't begin to describe it. Formatting undamaged. > > > > :-) Thanks. > > > > > This was previously reported as a security issue due to leakage of > > > uninitialized stack memory. Jeff Mahoney pointed out that this is > > > incorrect since the copied data is from a union (rather than a struct). > > > Therefore, this patch is only under consideration for the sake of > > > correctness, and is not security relevant. > > > > > > Signed-off-by: Dan Rosenberg <dan.j.rosenberg@gmail.com> > > > Acked-by: Grant Grundler <grundler@parisc-linux.org> > > > > Applied. > > David, just for the record, as was already reported on the list, this > fix is finally more a cleanup than a security fix because "tmp" is a > union and not a struct, so tmp.addr == tmp.lval.
sorry, that was already explained in the commit message, next time I'll read it fully before replying :-(
Willy
| |