Messages in this thread |  | | | Subject | Re: [PATCH] generic-ipi: fix deadlock in __smp_call_function_single | | From | Suresh Siddha <> | | Date | Fri, 17 Sep 2010 15:12:33 -0700 |
| |
On Tue, 2010-09-14 at 04:19 -0700, Heiko Carstens wrote: > > > > So what patches are we going to merge? > > > > I share Heiko's opinion on that its somewhat surprising to have > > __smp_call_function_single() differ in this detail from > > smp_call_function_single() and think that merging his patch would be > > good in that respect. But Andrew seemed to have reservations. > > > > We can also merge either my or Suresh's patch (which I think makes > > sense, but is kinda subtle) to avoid the needless self kick.
Peter, Can you please merge my patch instead of yours, as mine is more appropriate here. And also I would like Heiko's patch also to be merged as that brings smp_call_function_single() and __smp_call_function_single() to similar behavior.
thanks, suresh
> > I would prefer to see your's or Suresh's scheduler patch to be merged to > fix the bug. > My patch could be merged for 2.6.37 or be dropped in favour of a WARN_ON > in __smp_call_function_single() if remote cpu == current cpu. > However I think it would be better if smp_call_function_single() and > __smp_call_function_single() wouldn't differ here.
|  |