lkml.org 
[lkml]   [2010]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] generic-ipi: fix deadlock in __smp_call_function_single
From
Date
On Tue, 2010-09-14 at 04:19 -0700, Heiko Carstens wrote:
> >
> > So what patches are we going to merge?
> >
> > I share Heiko's opinion on that its somewhat surprising to have
> > __smp_call_function_single() differ in this detail from
> > smp_call_function_single() and think that merging his patch would be
> > good in that respect. But Andrew seemed to have reservations.
> >
> > We can also merge either my or Suresh's patch (which I think makes
> > sense, but is kinda subtle) to avoid the needless self kick.

Peter, Can you please merge my patch instead of yours, as mine is more
appropriate here. And also I would like Heiko's patch also to be merged
as that brings smp_call_function_single() and
__smp_call_function_single() to similar behavior.

thanks,
suresh

>
> I would prefer to see your's or Suresh's scheduler patch to be merged to
> fix the bug.
> My patch could be merged for 2.6.37 or be dropped in favour of a WARN_ON
> in __smp_call_function_single() if remote cpu == current cpu.
> However I think it would be better if smp_call_function_single() and
> __smp_call_function_single() wouldn't differ here.



\
 
 \ /
  Last update: 2010-09-18 00:15    [W:0.151 / U:0.748 seconds]
©2003-2014 Jasper Spaans. Advertise on this site