Messages in this thread | | | Date | Thu, 16 Sep 2010 14:53:55 +0200 | From | Jesse Barnes <> | Subject | Re: [PATCH] NULL pointer might be used in ips_monitor() |
| |
On Thu, 16 Sep 2010 13:06:28 +0800 minskey guo <chaohong.guo@linux.intel.com> wrote:
> From: minskey guo <chaohong_guo@linux.intel.com> > > The patch is to enable creating ips_adjust thread before ips_monitor > executes because the latter will kthread_stop() or wake up the former > via ips->adjust pointer. Otherwise, it is possible that ips->adjust > is NULL when kthread_stop() or wake_up_process() is called in > ips_monitor() > > Besides, some trival changes: > a) correct an define of register bits; > b) old_cpu_power sample should not be divided by 65535 > c) handling on error path in ips_get_i915_syms()
Excellent, thanks for the fixes. Can you split up the patch into individual fixes and send them over to the platform driver list and Matthew Garrett? You can add my acked-by on them.
Thanks, -- Jesse Barnes, Intel Open Source Technology Center
| |