Messages in this thread | | | Date | Wed, 15 Sep 2010 06:34:45 +0200 | From | Florian Mickler <> | Subject | Re: [PATCH] get_maintainer.pl: append reason for cc to the name by default |
| |
On Tue, 14 Sep 2010 20:28:44 -0700 Joe Perches <joe@perches.com> wrote:
> On Tue, 2010-09-14 at 19:46 +0200, Florian Mickler wrote: > > On Tue, 14 Sep 2010 10:19:33 -0700 > > ebiederm@xmission.com (Eric W. Biederman) wrote: > > > Florian Mickler <florian@mickler.org> writes: > > An interactive mode in git shortlog form of the last year should be > > possible, i guess. > > > > I wonder, if git send-email --cc-cmd allows for directing input towards > > get_maintainer.pl. That would be awesome. > > Yes it does. You could use any script or direct command > with arguments you like. > > I sent you privately a script that does that last week.
I think we misunderstand each other.
For the reference, you talk about this snippet? Or did I overlook smth?
$ cat scripts/send-email-listed-MAINTAINERS-only #!/bin/bash if [[ $(basename $1) =~ ^0000- ]] ; then ./scripts/get_maintainer.pl --nogit $(dirname $1)/* else ./scripts/get_maintainer.pl --nogit $1 fi
But for the interactive mode I had STDIN in mind. And now that I checked, it is indeed possible. I have a quick prove of concept for an get_maintainer.pl --interactive mode that shows you the cc's, lists their commits and let's you choose whom to add to the cc (using STDERR, as git-send-email.pl obviously expects adresses on STDOUT). I haven't experimented much with it, but if it works out expect a patch. But first I need some coffee and breakfast, as it's morning over here. :-)
Regards, Flo
| |